[libcamera-devel] [PATCH v3 7/7] libcamera: ipa: meson: build dummy IPA that needs isolation

[Laurent Pinchart]

Hi Paul,

Thank you for the patch.

On Wed, Jul 10, 2019 at 03:44:50AM +0900, Paul Elder wrote:
> Add the dummy IPA that needs isolation to meson. At the same time, clean
> up the IPA meson to facilitate adding more IPAs.
> 
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
> Changes in v3:
> - remove sub install directory for IPAs
> 
> Changes in v2:
> - make a sub install directory for IPAs, to keep them separate from the
>   proxies
> - remove shim compilation
> 
>  src/ipa/meson.build | 21 ++++++++++++---------
>  1 file changed, 12 insertions(+), 9 deletions(-)
> 
> diff --git a/src/ipa/meson.build b/src/ipa/meson.build
> index 3c33a37..2b9863b 100644
> --- a/src/ipa/meson.build
> +++ b/src/ipa/meson.build
> @@ -1,15 +1,18 @@
> -ipa_dummy_sources = files([
> -    'ipa_dummy.cpp',
> -])
> +ipa_dummy_sources = [
> +    ['ipa_dummy', 'ipa_dummy.cpp'],
> +    ['ipa_dummy_isolate', 'ipa_dummy_isolate.cpp'],
> +]
>  
>  ipa_install_dir = join_paths(get_option('libdir'), 'libcamera')
>  
> -ipa_dummy = shared_library('ipa_dummy',
> -                           ipa_dummy_sources,
> -                           name_prefix : '',
> -                           include_directories : libcamera_includes,
> -                           install : true,
> -                           install_dir : ipa_install_dir)
> +foreach t : ipa_dummy_sources
> +    ipa = shared_module(t[0],
> +                        t[1],
> +                        name_prefix : '',
> +                        include_directories : libcamera_includes,
> +                        install : true,
> +                        install_dir : ipa_install_dir)
> +endforeach
>  
>  config_h.set('IPA_MODULE_DIR',
>               '"' + join_paths(get_option('prefix'), ipa_install_dir) + '"')

-- 
Regards,

Laurent Pinchart