[libcamera-devel] [PATCH v2 4/6] include: linux: Add intel-ipu3 kernel header

[Laurent Pinchart]

Hi Jacopo,

On Tue, Jun 04, 2019 at 09:22:04AM +0200, Jacopo Mondi wrote:
> On Mon, Jun 03, 2019 at 11:16:16PM +0200, Niklas Söderlund wrote:
> > On 2019-05-27 11:05:57 +0200, Jacopo Mondi wrote:
> >> Add kernel header for Intel IPU3 from Linux v5.1.
> >>
> >> As the driver is currently in staging, the header file is not exported as
> >> part of the standard kernel uAPI.
> >>
> >> Manually export it using script/headers_install.sh and temporary copy it
> >> in libcamera's linux headers directory until it get not exported as
> >> part of the standard kernel headers in future Linux releases.
> >
> > The upstream header file is updated compared to this one and I think you
> > should refresh it from the media-tree. The media-tree/master also
> > contains the fix which you backport in 5/6 in this series.
> 
> Indeed, but media-tree is based on v5.2-rc2.
> 
> I would wait for v5.2 to land, and then update all our headers to that
> instead of updating this one only. Furthermore, this header is not
> even strictly required as long as we don't have anything dealing with
> IPU3's stats and params (so yes, not for long, but...)
> 
> I would not merge this patch and wait to have a real need for this
> header. Then, let's see which version will be more convenient to use,
> and maybe update other headers as well.

Let's not make it a blocker though, it's fine importing the header from
any kernel version, as long as we specify the exact upstream commit in
the commit message. I agree to wait until the header is needed, but it
will very likely be before v5.2.

> >> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> >> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> >> ---
> >>  include/linux/intel-ipu3.h | 2779 ++++++++++++++++++++++++++++++++++++
> >>  1 file changed, 2779 insertions(+)
> >>  create mode 100644 include/linux/intel-ipu3.h

-- 
Regards,

Laurent Pinchart