[libcamera-devel] [RFC PATCH 05/10] libcamera: ipa_module_info: add field for isolation

Paul Elder paul.elder at ideasonboard.com
Thu Jun 6 00:18:12 CEST 2019


Add a field to IPAModuleInfo that determines whether or not the IPA
module needs to be isolated in a separated process.

Also increment the IPA_MODULE_API_VERSION, due to the change to struct
IPAModuleInfo. Update the dummy IPA and IPA test to conform to the new
struct layout.

Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
---
 include/libcamera/ipa/ipa_module_info.h | 3 ++-
 src/ipa/ipa_dummy.cpp                   | 1 +
 test/ipa/ipa_test.cpp                   | 1 +
 3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/include/libcamera/ipa/ipa_module_info.h b/include/libcamera/ipa/ipa_module_info.h
index 585f753..cb112e4 100644
--- a/include/libcamera/ipa/ipa_module_info.h
+++ b/include/libcamera/ipa/ipa_module_info.h
@@ -9,7 +9,7 @@
 
 #include <stdint.h>
 
-#define IPA_MODULE_API_VERSION 1
+#define IPA_MODULE_API_VERSION 2
 
 namespace libcamera {
 
@@ -18,6 +18,7 @@ struct IPAModuleInfo {
 	uint32_t pipelineVersion;
 	char pipelineName[256];
 	char name[256];
+	int isolate;
 } __attribute__((packed));
 
 extern "C" {
diff --git a/src/ipa/ipa_dummy.cpp b/src/ipa/ipa_dummy.cpp
index ee7a3a8..a8ff88c 100644
--- a/src/ipa/ipa_dummy.cpp
+++ b/src/ipa/ipa_dummy.cpp
@@ -34,6 +34,7 @@ const struct IPAModuleInfo ipaModuleInfo = {
 	0,
 	"PipelineHandlerVimc",
 	"Dummy IPA for Vimc",
+	0,
 };
 
 IPAInterface *ipaCreate()
diff --git a/test/ipa/ipa_test.cpp b/test/ipa/ipa_test.cpp
index bbef069..2682bae 100644
--- a/test/ipa/ipa_test.cpp
+++ b/test/ipa/ipa_test.cpp
@@ -59,6 +59,7 @@ protected:
 			0,
 			"PipelineHandlerVimc",
 			"Dummy IPA for Vimc",
+			0,
 		};
 
 		count += runTest("src/ipa/ipa_dummy.so", testInfo);
-- 
2.20.1



More information about the libcamera-devel mailing list