[libcamera-devel] [PATCH 15/17] cam: Validate camera configuration

[Laurent Pinchart]

Hi Niklas,

Thank you for the patch.

On Mon, May 27, 2019 at 02:15:41AM +0200, Niklas Söderlund wrote:
> Use CameraConfiguration::validate() to validate and possibly update the
> camera configuration when its prepared.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/cam/main.cpp | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/src/cam/main.cpp b/src/cam/main.cpp
> index 338740d1512c7189..25538f5ba95552d6 100644
> --- a/src/cam/main.cpp
> +++ b/src/cam/main.cpp
> @@ -236,6 +236,18 @@ int CamApp::prepareConfig()
>  		}
>  	}
>  
> +	switch (config_->validate()) {
> +	case CameraConfiguration::Valid:
> +		break;
> +	case CameraConfiguration::Adjusted:
> +		std::cout << "Camera configuration adjusted" << std::endl;
> +		break;
> +	case CameraConfiguration::Invalid:
> +		std::cout << "Camera configuration invalid" << std::endl;
> +		config_.reset();
> +		return -EINVAL;
> +	}
> +
>  	return 0;
>  }
>  

-- 
Regards,

Laurent Pinchart