[libcamera-devel] [PATCH 3/3] libcamera: geometry: Fix SizeRange constructor style

Jacopo Mondi jacopo at jmondi.org
Tue Jun 11 08:06:55 CEST 2019


Hi Kieran,

On Mon, Jun 10, 2019 at 11:07:59PM +0100, Kieran Bingham wrote:
> Match the style of the SizeRange() which specifies the hStep and vStep,
> and wrap the lines in pairs of min and max values.
>
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
>  src/libcamera/geometry.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp
> index 97c367bcb454..fb8f628a0d8a 100644
> --- a/src/libcamera/geometry.cpp
> +++ b/src/libcamera/geometry.cpp
> @@ -197,7 +197,8 @@ bool operator<(const Size &lhs, const Size &rhs)
>   */
>
>  /**
> - * \fn SizeRange::SizeRange(unsigned int minW, unsigned int minH, unsigned int maxW, unsigned int maxH)
> + * \fn SizeRange::SizeRange(unsigned int minW, unsigned int minH,
> + *			    unsigned int maxW, unsigned int maxH)

I was not sure Doxygen interpret line break correctly.
I have generated the doc and it seems it does!

Thanks
Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

>   * \brief Construct an initialized size range
>   * \param[in] minW The minimum width
>   * \param[in] minH The minimum height
> --
> 2.20.1
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20190611/387efe9d/attachment.sig>


More information about the libcamera-devel mailing list