[libcamera-devel] [PATCH] libcamera: Fix CameraSensor::getFormat() search order

[Mickael GUENE]

Hi Jacopo,

 It's ok for me if you update with commit message changed.

regards
Mickael

On 6/11/19 14:50, Jacopo Mondi wrote:
> Hi Mickael,
>    thanks for the patch
> 
> On Tue, Jun 11, 2019 at 01:37:11PM +0200, Mickael Guene wrote:
>>  According to the documentation, CameraSensor::getFormat() should select Media
>> bus code from mbusCodes parameter list. It should select the first code from the
> s/from mbusCodes parameter list
>  /from mbusCodes parameters in descresing preference order/
>> list that is supported by the sensor. Current implementation will wrongly select
> 
> s/Current/However, the current/
> 
>> Media bus code from mbusCodes_ order instead.
>>  This patch aims to fix this wrong behavior.
> 
> I would change the last line with
> 
> "Fix this by first iterating on the mbus code list provided as parameter
> instead of iterating on the sensor supported formats".
> 
> If you agree with the change to the commit message, it could be
> updated when applying the patch.