[libcamera-devel] [PATCH v6 3/5] libcamera: v4l2_subdevice: Cosmetic update

[Laurent Pinchart]

Hi Jacopo,

Thank you for the patch.

On Fri, Mar 01, 2019 at 12:51:37PM +0100, Jacopo Mondi wrote:
> Cosmetic updated of V4L2Subdevice class: re-sort methods and comments to
> reflect the declaration order in the class definition.
> 
> Cosmetic update, no functional changes intended.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

Acked-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/v4l2_subdevice.cpp | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp
> index 07035886c766..de006b898af9 100644
> --- a/src/libcamera/v4l2_subdevice.cpp
> +++ b/src/libcamera/v4l2_subdevice.cpp
> @@ -54,6 +54,11 @@ LOG_DEFINE_CATEGORY(V4L2Subdev)
>   * Section 4.15.3.1 of the above mentioned Linux kernel documentation section.
>   */
>  
> +/**
> + * \var V4L2SubdeviceFormat::mbus_code
> + * \brief The image format bus code
> + */
> +
>  /**
>   * \var V4L2SubdeviceFormat::width
>   * \brief The image width in pixels
> @@ -64,11 +69,6 @@ LOG_DEFINE_CATEGORY(V4L2Subdev)
>   * \brief The image height in pixels
>   */
>  
> -/**
> - * \var V4L2SubdeviceFormat::mbus_code
> - * \brief The image format bus code
> - */
> -
>  /**
>   * \class V4L2Subdevice
>   * \brief A V4L2 subdevice as exposed by the Linux kernel
> @@ -154,11 +154,6 @@ void V4L2Subdevice::close()
>   * \return The name of the media entity the subdevice is associated to
>   */
>  
> -std::string V4L2Subdevice::logPrefix() const
> -{
> -	return "'" + deviceName() + "'";
> -}
> -
>  /**
>   * \brief Set a crop rectangle on one of the V4L2 subdevice pads
>   * \param[in] pad The 0-indexed pad number the rectangle is to be applied to
> @@ -299,6 +294,11 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format)
>  	return 0;
>  }
>  
> +std::string V4L2Subdevice::logPrefix() const
> +{
> +	return "'" + deviceName() + "'";
> +}
> +
>  std::vector<SizeRange> V4L2Subdevice::enumPadSizes(unsigned int pad,
>  						   unsigned int code)
>  {

-- 
Regards,

Laurent Pinchart