[libcamera-devel] [PATCH v7 0/5] v4l2_(sub)dev: improvements and tests

Jacopo Mondi jacopo at jmondi.org
Fri Mar 1 16:40:58 CET 2019


Hello,
  few minor changes to address Laurent's comments.

1) propagate error on ENUM_FRAME_SIZE (all errors != from EINVAL and ENOTTY,
   I wonder if subdevices can implement ENUM_MBUS but not ENUM_FRAME_SIZE
2) remove method reordering in v4l2_device cosmetic patch
3) use std::vector.empty() instead of (std::vector.size() == 0) in list
   formats test.

Hopefully this version might be pushed.

Thanks
   j

Jacopo Mondi (5):
  libcamera: v4l2_subdevice: Implement ENUM_FRAME_SIZES
  test: v4l2_subdevice: Add ListFormat test
  libcamera: v4l2_subdevice: Cosmetic update
  libcamera: v4l2_device: Add support for META_CAPTURE devices
  libcamera: v4l2_device: Cosmetic update

 src/libcamera/geometry.cpp             |  34 ++++++++
 src/libcamera/include/geometry.h       |  12 +++
 src/libcamera/include/v4l2_device.h    |  26 +++++-
 src/libcamera/include/v4l2_subdevice.h |  11 ++-
 src/libcamera/v4l2_device.cpp          |  92 ++++++++++++++-------
 src/libcamera/v4l2_subdevice.cpp       | 107 ++++++++++++++++++++++---
 test/v4l2_subdevice/list_formats.cpp   |  81 +++++++++++++++++++
 test/v4l2_subdevice/meson.build        |   1 +
 8 files changed, 321 insertions(+), 43 deletions(-)
 create mode 100644 test/v4l2_subdevice/list_formats.cpp

--
2.20.1



More information about the libcamera-devel mailing list