[libcamera-devel] [PATCH v3 0/4] test: camera: Add basic tests for the camera

[Kieran Bingham]

Hi Niklas,

On 13/03/2019 01:05, Niklas Söderlund wrote:
> Hi,
> 
> This series add basic tests for the camera implementation. The tests
> involve reading and setting configurations, access control of the state
> machine and capturing.
> 
> All tests uses the vimc pipeline to allow the tests to run on as many
> platforms as possible. Down the line this might be expanded to run an
> all cameras detected by libcamera.
> 
> All patches in the series are reviewed but I feel that posting it for 
> one more round is the right thing to do. If no comments come to light 
> within a day or two I aim to push this series. If you wish to review 
> this but don't have time ping and I will delay until you have had time 
> to do so.


These look good to me.

For the series,

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>


> 
> * Changes since v2
> - Update all error messages if a test should fail.
> 
> 
> Niklas Söderlund (4):
>   test: camera: Add read default configuration test
>   test: camera: Add setting of configuration test
>   test: camera: Add capture test
>   test: camera: Add state machine test
> 
>  test/camera/camera_test.cpp           |  74 +++++++
>  test/camera/camera_test.h             |  35 ++++
>  test/camera/capture.cpp               | 142 +++++++++++++
>  test/camera/configuration_default.cpp |  71 +++++++
>  test/camera/configuration_set.cpp     |  91 +++++++++
>  test/camera/meson.build               |  15 ++
>  test/camera/statemachine.cpp          | 275 ++++++++++++++++++++++++++
>  test/meson.build                      |   1 +
>  8 files changed, 704 insertions(+)
>  create mode 100644 test/camera/camera_test.cpp
>  create mode 100644 test/camera/camera_test.h
>  create mode 100644 test/camera/capture.cpp
>  create mode 100644 test/camera/configuration_default.cpp
>  create mode 100644 test/camera/configuration_set.cpp
>  create mode 100644 test/camera/meson.build
>  create mode 100644 test/camera/statemachine.cpp
> 

-- 
Regards
--
Kieran