[libcamera-devel] [PATCH] libcamera: media_device: Initialise local variable

[Kieran Bingham]

The local variable ifaceId generates a compiler warning that it is used
without initialisation.

The loop, and check against the loop iterator, and the
topology.num_interfaces actually ensures that this isn't the case, and
that ifaceId can only be used when set to a valid ID.

The media_v2_interface.id field documents the ID as simply "Unique ID
for the interface" but does not specify if zero is a valid ID or not. As
such we don't further check the pre-initialised ID for validity and keep
the existing check on the iterator count to determine if the ID had been
discovered successfully.

Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
---
 src/libcamera/media_device.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp
index ea4608932834..1e9024bf9721 100644
--- a/src/libcamera/media_device.cpp
+++ b/src/libcamera/media_device.cpp
@@ -516,7 +516,7 @@ struct media_v2_interface *MediaDevice::findInterface(const struct media_v2_topo
 {
 	struct media_v2_link *links = reinterpret_cast<struct media_v2_link *>
 						      (topology.ptr_links);
-	unsigned int ifaceId;
+	unsigned int ifaceId = 0;
 	unsigned int i;
 
 	for (i = 0; i < topology.num_links; ++i) {
-- 
2.19.1