[libcamera-devel] [PATCH v4 14/31] HACK: Soraka: Limit resolution to 2560x1920

[Laurent Pinchart]

Hi Jacopo,

Thank you for the patch.

As this patch will need to be merged, let's give it the right
"libcamera: ipu3:" prefix.

On Wed, Mar 20, 2019 at 05:30:38PM +0100, Jacopo Mondi wrote:
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> ---
>  src/libcamera/pipeline/ipu3/ipu3.cpp | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
> index b99aae95c6d7..ed2409907cf0 100644
> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
> @@ -214,6 +214,16 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera,
>  		}
>  	}
>  
> +	/*
> +	 * FIXME: Soraka: the maximum resolution reported by both sensors
> +	 * (2592x1944 for ov5670 and 4224x3136 for ov13858) are returned as
> +	 * default configurations but they're not correctly processed by the
> +	 * ImgU. Resolutions up tp 2560x1920 have been validated.

s/up tp/up to/

What's happening when you try to capture in a higher resolution ?

> +	 *
> +	 * \todo Clarify ImgU alignement requirements.
> +	 */
> +	config->width = 2560;
> +	config->height = 1920;
>  	config->pixelFormat = V4L2_PIX_FMT_NV12;
>  	config->bufferCount = IPU3_BUFFER_COUNT;
>  
> -- 
> 2.21.0
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

-- 
Regards,

Laurent Pinchart