[libcamera-devel] [PATCH] libcamera: stream: Qualify 'Camera' friend directive

Laurent Pinchart laurent.pinchart at ideasonboard.com
Fri Mar 29 15:37:07 CET 2019


Hi Jacopo,

Thank you for the patch.

On Fri, Mar 29, 2019 at 12:13:07PM +0100, Jacopo Mondi wrote:
> Align the Stream class to all other classes in the code base to use the
> 'class' qualifier in 'friend' declarations.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  include/libcamera/stream.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h
> index 24407cb65361..970c479627fa 100644
> --- a/include/libcamera/stream.h
> +++ b/include/libcamera/stream.h
> @@ -29,7 +29,7 @@ public:
>  	const StreamConfiguration &configuration() const { return configuration_; }
> 
>  private:
> -	friend Camera;
> +	friend class Camera;
> 
>  	BufferPool bufferPool_;
>  	StreamConfiguration configuration_;

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list