[libcamera-devel] [PATCH] tests: list_formats: Fix argument names and add const

[Niklas Söderlund]

Hi,

I have pushed this to master with Laurent's tag, thanks!

On 2019-05-25 06:44:42 +0300, Laurent Pinchart wrote:
> Hi Niklas,
> 
> Thank you for the patch.
> 
> On Sat, May 25, 2019 at 02:22:29AM +0200, Niklas Söderlund wrote:
> > Argument name differs from definition and implementation, fix it by
> > renaming the definition. While at it make the argument const.
> > 
> > Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> 
> > ---
> >  test/v4l2_subdevice/list_formats.cpp | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/test/v4l2_subdevice/list_formats.cpp b/test/v4l2_subdevice/list_formats.cpp
> > index 18dd8761a8ab408f..3f0edafcdcd72d6b 100644
> > --- a/test/v4l2_subdevice/list_formats.cpp
> > +++ b/test/v4l2_subdevice/list_formats.cpp
> > @@ -26,15 +26,15 @@ protected:
> >  
> >  private:
> >  	void printFormats(unsigned int pad, unsigned code,
> > -			  std::vector<SizeRange> &formats);
> > +			  const std::vector<SizeRange> &sizes);
> >  };
> >  
> >  void ListFormatsTest::printFormats(unsigned int pad,
> >  				   unsigned int code,
> > -				   std::vector<SizeRange> &sizes)
> > +				   const std::vector<SizeRange> &sizes)
> >  {
> >  	cout << "Enumerate formats on pad " << pad << endl;
> > -	for (SizeRange &size : sizes) {
> > +	for (const SizeRange &size : sizes) {
> >  		cout << "	mbus code: 0x" << setfill('0') << setw(4)
> >  		     << hex << code << endl;
> >  		cout << "	min width: " << dec << size.min.width << endl;
> 
> -- 
> Regards,
> 
> Laurent Pinchart

-- 
Regards,
Niklas Söderlund