[libcamera-devel] [PATCH 10/17] libcamera: stream: Define log object

Kieran Bingham kieran.bingham at ideasonboard.com
Wed May 29 23:47:15 CEST 2019


Hi Niklas,

On 27/05/2019 01:15, Niklas Söderlund wrote:
> Define a LOG object to prepare for adding code which needs to write to
> the log.
> 

I think this could have been squashed into the first usage that adds a
LOG(), but I'm sure it's fine here if you really want it split.

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
> ---
>  src/libcamera/stream.cpp | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp
> index 0c59a31a3a0501d3..eecd37160150d55c 100644
> --- a/src/libcamera/stream.cpp
> +++ b/src/libcamera/stream.cpp
> @@ -10,6 +10,8 @@
>  #include <iomanip>
>  #include <sstream>
>  
> +#include "log.h"
> +
>  /**
>   * \file stream.h
>   * \brief Video stream for a Camera
> @@ -32,6 +34,8 @@
>  
>  namespace libcamera {
>  
> +LOG_DEFINE_CATEGORY(Stream)
> +
>  /**
>   * \struct StreamConfiguration
>   * \brief Configuration parameters for a stream
> 

-- 
Regards
--
Kieran


More information about the libcamera-devel mailing list