[libcamera-devel] [PATCH v2 07/24] libcamera: controls: Make ControlId constructor public

Laurent Pinchart laurent.pinchart at ideasonboard.com
Fri Nov 8 21:53:52 CET 2019


From: Jacopo Mondi <jacopo at jmondi.org>

In order to be able to create a ControlId from serialized data, make its
constructor public.

Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
---
 include/libcamera/controls.h | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h
index 548c06c65bb6..6bad36cbc369 100644
--- a/include/libcamera/controls.h
+++ b/include/libcamera/controls.h
@@ -59,16 +59,15 @@ private:
 class ControlId
 {
 public:
-	unsigned int id() const { return id_; }
-	const std::string &name() const { return name_; }
-	ControlType type() const { return type_; }
-
-protected:
 	ControlId(unsigned int id, const std::string &name, ControlType type)
 		: id_(id), name_(name), type_(type)
 	{
 	}
 
+	unsigned int id() const { return id_; }
+	const std::string &name() const { return name_; }
+	ControlType type() const { return type_; }
+
 private:
 	ControlId &operator=(const ControlId &) = delete;
 	ControlId(const ControlId &) = delete;
-- 
Regards,

Laurent Pinchart



More information about the libcamera-devel mailing list