[libcamera-devel] [PATCH 02/10] libcamera: buffer: Plane: Drop friend statement

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Nov 18 12:17:04 CET 2019


Hi Niklas,

Thank you for the patch.

On Mon, Oct 28, 2019 at 03:22:16AM +0100, Niklas Söderlund wrote:
> The Plane class do not need to friend Stream, drop it.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  include/libcamera/buffer.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h
> index e14c9bd390a13bfc..d7784d9d24ab3f41 100644
> --- a/include/libcamera/buffer.h
> +++ b/include/libcamera/buffer.h
> @@ -29,8 +29,6 @@ public:
>  	unsigned int length() const { return length_; }
>  
>  private:
> -	friend class Stream;
> -
>  	int mmap();
>  	int munmap();
>  

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list