[libcamera-devel] [PATCH 07/10] libcamera: pipeline_handler: Do not use argument as local variable

[Laurent Pinchart]

Hi Niklas,

Thank you for the patch.

On Mon, Oct 28, 2019 at 03:22:21AM +0100, Niklas Söderlund wrote:
> In completeRequest() the request argument is used as a local variable,
> this is confusing. Add a separate local variable instead of reusing the
> argument.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/pipeline_handler.cpp | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp
> index bf8c86d35c4fb6f4..f9ae767d529d44d9 100644
> --- a/src/libcamera/pipeline_handler.cpp
> +++ b/src/libcamera/pipeline_handler.cpp
> @@ -409,13 +409,13 @@ void PipelineHandler::completeRequest(Camera *camera, Request *request)
>  	CameraData *data = cameraData(camera);
>  
>  	while (!data->queuedRequests_.empty()) {
> -		request = data->queuedRequests_.front();
> -		if (request->status() == Request::RequestPending)
> +		Request *req = data->queuedRequests_.front();
> +		if (req->status() == Request::RequestPending)
>  			break;
>  
> -		ASSERT(!request->hasPendingBuffers());
> +		ASSERT(!req->hasPendingBuffers());
>  		data->queuedRequests_.pop_front();
> -		camera->requestComplete(request);
> +		camera->requestComplete(req);
>  	}
>  }
>  

-- 
Regards,

Laurent Pinchart