[libcamera-devel] [PATCH 1/5] test: message: Fix message handling in MessageReceiver

Jacopo Mondi jacopo at jmondi.org
Wed Nov 27 10:27:57 CET 2019


Hi Laurent,

On Wed, Nov 27, 2019 at 10:49:05AM +0200, Laurent Pinchart wrote:
> Forward messages that we don't handle to the base Object class, to avoid
> both blocking the ThreadMove message and mistaking it as the test
> message.

I've not been following the issue too closely, so I can only partially
grasp it, but all the patches look sane to me

For the series:
Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

Thanks
   j

>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  test/message.cpp | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/test/message.cpp b/test/message.cpp
> index 3775c30a20b3..cf21d5ca50d1 100644
> --- a/test/message.cpp
> +++ b/test/message.cpp
> @@ -37,6 +37,11 @@ public:
>  protected:
>  	void message(Message *msg)
>  	{
> +		if (msg->type() != Message::None) {
> +			Object::message(msg);
> +			return;
> +		}
> +
>  		if (thread() != Thread::current())
>  			status_ = InvalidThread;
>  		else
> --
> Regards,
>
> Laurent Pinchart
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20191127/d33d6dc4/attachment.sig>


More information about the libcamera-devel mailing list