[libcamera-devel] [PATCH v4 03/11] libcamera: controls: Add AeLocked control

[Laurent Pinchart]

Hi Niklas,

Thank you for the patch.

On Thu, Oct 03, 2019 at 07:49:33PM +0200, Niklas Söderlund wrote:
> Add a control to report lock status of the Auto Exposure algorithm. The
> idea is that if an AE algorithm is running the control shall be added to
> the meta data control list.
> 
> If the AE algorithm is locked the value shall be set to true, if it's
> converging it shall be set to false. If the AE algorithm is not running
> the control shall not be present in the meta data control list.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
> ---
>  src/libcamera/control_ids.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
> index 4626f6ef48bcaeea..142bdede2b96c0e0 100644
> --- a/src/libcamera/control_ids.yaml
> +++ b/src/libcamera/control_ids.yaml
> @@ -12,6 +12,13 @@ controls:
>  
>          \sa ManualExposure
>  
> +  - AeLocked:
> +      type: bool
> +      description: |
> +        Report the lock status of a running AE algorithm.

I think you should capture here the documentation from the commit
message. With that fixed,

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> +
> +        \sa AeEnable
> +
>    - AwbEnable:
>        type: bool
>        description: |

-- 
Regards,

Laurent Pinchart