[libcamera-devel] [PATCH v2 3/6] ipa: ipa_manager: Print the loaded IPA modules path

[Laurent Pinchart]

Hi Jacopo,

Thank you for the patch.

On Fri, Oct 04, 2019 at 06:37:31PM +0200, Jacopo Mondi wrote:
> Add debug message to report which IPA modules have been loaded and in
> which order.
> 
> The loading order is particularly relevant for the test VIMC IPA, as the
> same IPA is compiled with an open source license tag and a proprietary
> one and they both match() against the VIMC pipeline handler. Being
> informed about their loading order is helpful to understand which one of
> the two is actually in use.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

but pushed already (as a standalone patch) :-)

> ---
>  src/libcamera/ipa_manager.cpp | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp
> index 27aa17920bab..f3180c0739cb 100644
> --- a/src/libcamera/ipa_manager.cpp
> +++ b/src/libcamera/ipa_manager.cpp
> @@ -136,6 +136,8 @@ int IPAManager::addDir(const char *libDir)
>  			continue;
>  		}
>  
> +		LOG(IPAManager, Debug) << "Loaded IPA module '" << path << "'";
> +
>  		modules_.push_back(ipaModule);
>  		count++;
>  	}

-- 
Regards,

Laurent Pinchart