[libcamera-devel] [PATCH 05/10] test: v4l2_videodevice: controls: Use correct control range in check

[Jacopo Mondi]

Hi Laurent,

On Mon, Oct 14, 2019 at 02:27:51AM +0300, Laurent Pinchart wrote:
> A value check on the V4L2_CID_CONTRAST control is using the brightness
> control range. Fix it.
>

Ouch! Thanks for fixing
Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

Thanks
  j

> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  test/v4l2_videodevice/controls.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/v4l2_videodevice/controls.cpp b/test/v4l2_videodevice/controls.cpp
> index e59387ab9eba..3add6e67d2cf 100644
> --- a/test/v4l2_videodevice/controls.cpp
> +++ b/test/v4l2_videodevice/controls.cpp
> @@ -87,7 +87,7 @@ protected:
>  		}
>
>  		if (ctrls.get(V4L2_CID_BRIGHTNESS) != brightness.range().min() ||
> -		    ctrls.get(V4L2_CID_CONTRAST) != brightness.range().max() ||
> +		    ctrls.get(V4L2_CID_CONTRAST) != contrast.range().max() ||
>  		    ctrls.get(V4L2_CID_SATURATION) != saturation.range().min().get<int32_t>() + 1) {
>  			cerr << "Controls not updated when set" << endl;
>  			return TestFail;
> --
> Regards,
>
> Laurent Pinchart
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20191015/892af96b/attachment.sig>