[libcamera-devel] [PATCH] libcamera: pipeline_handler: Fix trivial spelling

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sun Oct 20 09:13:57 CEST 2019


Hi Kieran,

Thank you for the patch.

On Fri, Oct 18, 2019 at 04:39:20PM +0100, Kieran Bingham wrote:
> Signaled is an American spelling.
> 
>   s/signaled/signalled/

You know that's a lost fight, right ? :-) I however value consistency,
and as with started with UK spelling, we can continue with it. Care to
implement support for spell checking in checkstyle.py ? :-)

Acked-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> Fixes: b2c06cf40975 ("libcamera: Handle request completion explicitly in pipeline handlers")
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
>  src/libcamera/pipeline_handler.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp
> index cb4337e50eb6..bf8c86d35c4f 100644
> --- a/src/libcamera/pipeline_handler.cpp
> +++ b/src/libcamera/pipeline_handler.cpp
> @@ -353,7 +353,7 @@ const ControlInfoMap &PipelineHandler::controls(Camera *camera)
>   * Pipeline handlers shall override this method. The base implementation in the
>   * PipelineHandler class keeps track of queued requests in order to ensure
>   * completion of all requests when the pipeline handler is stopped with stop().
> - * Requests completion shall be signaled by the pipeline handler using the
> + * Requests completion shall be signalled by the pipeline handler using the
>   * completeRequest() method.
>   *
>   * \return 0 on success or a negative error code otherwise

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list