[libcamera-devel] [PATCH] libcamera: controls: Remove rogue '; '

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Oct 22 15:55:41 CEST 2019


Hi Jacopo,

Thank you for the patch.

On Tue, Oct 22, 2019 at 03:35:51PM +0200, Jacopo Mondi wrote:
> The ';' at the end of an inline method declaration is not required.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  include/libcamera/controls.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h
> index 0d279d508dcc..42e6df7e613d 100644
> --- a/include/libcamera/controls.h
> +++ b/include/libcamera/controls.h
> @@ -30,8 +30,8 @@ public:
>  	ControlValue(int32_t value);
>  	ControlValue(int64_t value);
>  
> -	ControlType type() const { return type_; };
> -	bool isNone() const { return type_ == ControlTypeNone; };
> +	ControlType type() const { return type_; }
> +	bool isNone() const { return type_ == ControlTypeNone; }
>  
>  	template<typename T>
>  	const T &get() const;

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list