[libcamera-devel] [PATCH 3/4] utils: checkstyle.py: Add include checker
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Wed Oct 23 16:08:53 CEST 2019
This is missing a commit message, sorry :-S
Add an include checker to verify usage of the C compatibility headers.
Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
On Wed, Oct 23, 2019 at 04:52:57PM +0300, Laurent Pinchart wrote:
> ---
> utils/checkstyle.py | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/utils/checkstyle.py b/utils/checkstyle.py
> index 42a96f6d6102..335e58f5fddf 100755
> --- a/utils/checkstyle.py
> +++ b/utils/checkstyle.py
> @@ -240,6 +240,38 @@ class StyleIssue(object):
> self.msg = msg
>
>
> +class IncludeChecker(StyleChecker):
> + patterns = ('*.cpp', '*.h')
> +
> + headers = ('assert', 'ctype', 'errno', 'fenv', 'float', 'inttypes',
> + 'limits', 'locale', 'math', 'setjmp', 'signal', 'stdarg',
> + 'stddef', 'stdint', 'stdio', 'stdlib', 'string', 'time', 'uchar',
> + 'wchar', 'wctype')
> + include_regex = re.compile('^#include <c([a-z]*)>')
> +
> + def __init__(self, content):
> + super().__init__()
> + self.__content = content
> +
> + def check(self, line_numbers):
> + issues = []
> +
> + for line_number in line_numbers:
> + line = self.__content[line_number - 1]
> + match = IncludeChecker.include_regex.match(line)
> + if not match:
> + continue
> +
> + header = match.group(1)
> + if header not in IncludeChecker.headers:
> + continue
> +
> + issues.append(StyleIssue(line_number, line,
> + 'C compatibility header <%s.h> is preferred' % header))
> +
> + return issues
> +
> +
> class LogCategoryChecker(StyleChecker):
> log_regex = re.compile('\\bLOG\((Debug|Info|Warning|Error|Fatal)\)')
> patterns = ('*.cpp',)
> --
> Regards,
>
> Laurent Pinchart
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list