[libcamera-devel] [PATCH] libcamera: bound_method: Fix compiler warning due to unused arguments

Jacopo Mondi jacopo at jmondi.org
Sat Oct 26 23:32:28 CEST 2019


Hi Laurent

On Sun, Oct 27, 2019 at 12:17:43AM +0300, Laurent Pinchart wrote:
> The BoundStaticMethod::invoke() method is never used, but must still be
> implemented as the base class defines it as pure virtual. As it doesn't
> use its arguments, the compiler generates a warning. Fix it.
>

Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

Thanks
   j

> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  include/libcamera/bound_method.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h
> index 54c40fc52e3b..8ebaadbec887 100644
> --- a/include/libcamera/bound_method.h
> +++ b/include/libcamera/bound_method.h
> @@ -119,7 +119,7 @@ public:
>  	bool match(void (*func)(Args...)) const { return func == func_; }
>
>  	void activate(Args... args) { (*func_)(args...); }
> -	void invoke(Args... args) {}
> +	void invoke(Args...) {}
>
>  private:
>  	void (*func_)(Args...);
> --
> Regards,
>
> Laurent Pinchart
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20191026/db0b0dc8/attachment.sig>


More information about the libcamera-devel mailing list