[libcamera-devel] [PATCH 5/6] test: object-invoke: invoke method in blocking mode

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Oct 28 00:41:06 CET 2019


On Sun, Oct 27, 2019 at 09:33:34PM +0100, Jacopo Mondi wrote:
> Change the object-invoke test to perform the second method invocation
> operation in blocking mode.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> ---
>  test/object-invoke.cpp | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/test/object-invoke.cpp b/test/object-invoke.cpp
> index 6e0e24b146f0..4ae8c91ab7f0 100644
> --- a/test/object-invoke.cpp
> +++ b/test/object-invoke.cpp
> @@ -102,8 +102,7 @@ protected:
>  		thread_.start();
>  
>  		object.invokeMethod(&InvokedObject::method,
> -				    InvocationTypeAuto, 42);
> -		this_thread::sleep_for(chrono::milliseconds(100));
> +				    InvocationTypeBlocking, 42);

The indentation is wrong here.

With this change, I think you can remote #include <chrono> at the top of
the file. Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

>  
>  		switch (object.status()) {
>  		case InvokedObject::NoCall:

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list