[libcamera-devel] [PATCH 10/10] test: camera: buffer_import: Use DRM/KMS format

[Laurent Pinchart]

Hi Jacopo,

Thank you for the patch.

On Mon, Oct 28, 2019 at 12:43:12AM +0100, Jacopo Mondi wrote:
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> ---
>  test/camera/buffer_import.cpp | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp
> index 9cac19d8ce81..8411e69bbd09 100644
> --- a/test/camera/buffer_import.cpp
> +++ b/test/camera/buffer_import.cpp
> @@ -13,6 +13,8 @@
>  #include <random>
>  #include <vector>
>  
> +#include <linux/drm_fourcc.h>
> +
>  #include "device_enumerator.h"
>  #include "media_device.h"
>  #include "v4l2_videodevice.h"
> @@ -79,7 +81,7 @@ public:
>  
>  		format_.size.width = 1920;
>  		format_.size.height = 1080;
> -		format_.fourcc = V4L2_PIX_FMT_RGB24;
> +		format_.fourcc = DRM_FORMAT_BGR888;
>  		format_.planesCount = 1;
>  		format_.planes[0].size = 1920 * 1080 * 3;
>  		format_.planes[0].bpl = 1920 * 3;

This is actually not Reviewed-by as it breaks the test :-) format_ here
is a V4L2DeviceFormat so it should use V4L2 4CCs. You can just drop this
patch.

-- 
Regards,

Laurent Pinchart