[libcamera-devel] [PATCH v4 4/7] android: camera_device: Add missing tags in request template

[Laurent Pinchart]

Hi Jacopo,

Thank you for the patch.

On Wed, Sep 04, 2019 at 02:54:24PM +0200, Jacopo Mondi wrote:
> Add two missing tags from the request template generated by the HAL.
> The tags are reported as missing by the cros_camera_test tool.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/android/camera_device.cpp | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
> index bd69198ec482..969c8192c316 100644
> --- a/src/android/camera_device.cpp
> +++ b/src/android/camera_device.cpp
> @@ -611,6 +611,17 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)
>  			&faceDetectMode, 1);
>  	METADATA_ASSERT(ret);
>  
> +	uint8_t noiseReduction = ANDROID_NOISE_REDUCTION_MODE_OFF;
> +	ret = add_camera_metadata_entry(requestTemplate_,
> +			ANDROID_NOISE_REDUCTION_MODE, &noiseReduction, 1);
> +	METADATA_ASSERT(ret);
> +
> +	uint8_t aberrationMode = ANDROID_COLOR_CORRECTION_ABERRATION_MODE_OFF;
> +	ret = add_camera_metadata_entry(requestTemplate_,
> +			ANDROID_COLOR_CORRECTION_ABERRATION_MODE,
> +			&aberrationMode, 1);
> +	METADATA_ASSERT(ret);
> +
>  	ret = add_camera_metadata_entry(requestTemplate_,
>  			ANDROID_CONTROL_CAPTURE_INTENT,
>  			&captureIntent, 1);

-- 
Regards,

Laurent Pinchart