[libcamera-devel] [PATCH 1/5] libcamera: Create DataValue and DataInfo

[Kieran Bingham]

Hi Jacopo,

On 23/09/2019 12:02, Jacopo Mondi wrote:
> Hi Kieran,
> 
> On Fri, Sep 20, 2019 at 11:03:55AM +0100, Kieran Bingham wrote:
>> Hi Jacopo,
>>

<snip>

>>> +TEST_REGISTER(DataValueTest)
>>> diff --git a/test/data_value/meson.build b/test/data_value/meson.build
>>> new file mode 100644
>>> index 000000000000..3858e6085a1f
>>> --- /dev/null
>>> +++ b/test/data_value/meson.build
>>> @@ -0,0 +1,12 @@
>>> +data_value_tests = [
>>> +    [ 'data_value',   'data_value.cpp' ],
>>> +]
>>> +
>>> +foreach t : data_value_tests
>>> +    exe = executable(t[0], t[1],
>>> +                     dependencies : libcamera_dep,
>>> +                     link_with : test_libraries,
>>> +                     include_directories : test_includes_internal)
>>> +    test(t[0], exe, suite : 'data_value', is_parallel : false)
>>> +endforeach
>>
>>
>> Does data_value need a whole subdirectory for a single test? Will it
>> have multiple tests in the (near) future?
> 
> I thought so, but in the end I only added one
> 
>>
>> I really dislike adding a subdirectory/test suite just for a single test
>> unless we really know it's going to be extended.
>>
> 
> Where would you put this?

just test/data_value.cpp for the moment!

>> Regards
>> --
>> Kieran

-- 
Regards
--
Kieran