[libcamera-devel] [PATCH 04/11] test: Add File class tests
Niklas Söderlund
niklas.soderlund at ragnatech.se
Tue Apr 7 22:24:04 CEST 2020
Hi Laurent,
Thanks for your work.
On 2020-04-04 04:56:17 +0300, Laurent Pinchart wrote:
> Add tests for the File class API.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> test/file.cpp | 285 +++++++++++++++++++++++++++++++++++++++++++++++
> test/meson.build | 1 +
> 2 files changed, 286 insertions(+)
> create mode 100644 test/file.cpp
>
> diff --git a/test/file.cpp b/test/file.cpp
> new file mode 100644
> index 000000000000..c046bced1c13
> --- /dev/null
> +++ b/test/file.cpp
> @@ -0,0 +1,285 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/*
> + * Copyright (C) 2020, Google Inc.
> + *
> + * file.cpp - File I/O operations tests
> + */
> +
> +#include <fstream>
> +#include <iostream>
> +#include <string>
> +#include <string.h>
> +#include <sys/types.h>
> +#include <unistd.h>
> +
> +#include "file.h"
> +#include "test.h"
> +
> +using namespace std;
> +using namespace libcamera;
> +
> +class FileTest : public Test
> +{
> +protected:
> + int init()
> + {
> + fileName_ = "/tmp/libcamera.test." + std::to_string(getpid());
I think this should use mktemp(), not everyone have the same /tmp ;-P
As the File interface uses an API where the error is signaled using
File::error() shall it not be tested here as well? But we can always add
that on top.
With mktemp() sorted,
Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
> +
> + std::ofstream ostrm(fileName_, ios::binary);
> + ostrm << "libcamera";
> + ostrm.close();
> +
> + return TestPass;
> + }
> +
> + int run()
> + {
> + /* Test static functions. */
> + if (!File::exists("/dev/null")) {
> + cerr << "Valid file not found" << endl;
> + return TestFail;
> + }
> +
> + if (File::exists("/dev/null/invalid")) {
> + cerr << "Invalid file should not exist" << endl;
> + return TestFail;
> + }
> +
> + /* Test unnamed file. */
> + File file;
> +
> + if (!file.fileName().empty()) {
> + cerr << "Unnamed file has non-empty file name" << endl;
> + return TestFail;
> + }
> +
> + if (file.exists()) {
> + cerr << "Unnamed file exists" << endl;
> + return TestFail;
> + }
> +
> + if (file.isOpen()) {
> + cerr << "File is open after construction" << endl;
> + return TestFail;
> + }
> +
> + if (file.openMode() != File::NotOpen) {
> + cerr << "File has invalid open mode after construction"
> + << endl;
> + return TestFail;
> + }
> +
> + if (file.size() >= 0) {
> + cerr << "Unnamed file has a size" << endl;
> + return TestFail;
> + }
> +
> + if (file.open(File::ReadWrite)) {
> + cerr << "Opening unnamed file succeeded" << endl;
> + return TestFail;
> + }
> +
> + /* Test named file referring to an invalid file. */
> + file.setFileName("/dev/null/invalid");
> +
> + if (file.fileName() != "/dev/null/invalid") {
> + cerr << "File reports incorrect file name" << endl;
> + return TestFail;
> + }
> +
> + if (file.exists()) {
> + cerr << "Invalid file exists" << endl;
> + return TestFail;
> + }
> +
> + if (file.isOpen()) {
> + cerr << "Invalid file is open after construction" << endl;
> + return TestFail;
> + }
> +
> + if (file.openMode() != File::NotOpen) {
> + cerr << "Invalid file has invalid open mode after construction"
> + << endl;
> + return TestFail;
> + }
> +
> + if (file.size() >= 0) {
> + cerr << "Invalid file has a size" << endl;
> + return TestFail;
> + }
> +
> + if (file.open(File::ReadWrite)) {
> + cerr << "Opening invalid file succeeded" << endl;
> + return TestFail;
> + }
> +
> + /* Test named file referring to a valid file. */
> + file.setFileName("/dev/null");
> +
> + if (!file.exists()) {
> + cerr << "Valid file does not exist" << endl;
> + return TestFail;
> + }
> +
> + if (file.isOpen()) {
> + cerr << "Valid file is open after construction" << endl;
> + return TestFail;
> + }
> +
> + if (file.openMode() != File::NotOpen) {
> + cerr << "Valid file has invalid open mode after construction"
> + << endl;
> + return TestFail;
> + }
> +
> + if (file.size() >= 0) {
> + cerr << "Invalid file has a size" << endl;
> + return TestFail;
> + }
> +
> + /* Test open and close. */
> + if (!file.open(File::ReadWrite)) {
> + cerr << "Opening file failed" << endl;
> + return TestFail;
> + }
> +
> + if (!file.isOpen()) {
> + cerr << "Open file reported as closed" << endl;
> + return TestFail;
> + }
> +
> + if (file.openMode() != File::ReadWrite) {
> + cerr << "Open file has invalid open mode" << endl;
> + return TestFail;
> + }
> +
> + file.close();
> +
> + if (file.isOpen()) {
> + cerr << "Closed file reported as open" << endl;
> + return TestFail;
> + }
> +
> + if (file.openMode() != File::NotOpen) {
> + cerr << "Closed file has invalid open mode" << endl;
> + return TestFail;
> + }
> +
> + /* Test size(). */
> + file.setFileName("/proc/self/exe");
> +
> + if (file.size() >= 0) {
> + cerr << "File has valid size before open" << endl;
> + return TestFail;
> + }
> +
> + file.open(File::ReadOnly);
> +
> + ssize_t size = file.size();
> + if (size <= 0) {
> + cerr << "File has invalid size after open" << endl;
> + return TestFail;
> + }
> +
> + /* Test mapping and unmapping. */
> + Span<uint8_t> data = file.map();
> + if (data.empty()) {
> + cerr << "Mapping of complete file failed" << endl;
> + return TestFail;
> + }
> +
> + if (data.size() != static_cast<size_t>(size)) {
> + cerr << "Mapping of complete file has invalid size" << endl;
> + return TestFail;
> + }
> +
> + if (!file.unmap(data.data())) {
> + cerr << "Unmapping of complete file failed" << endl;
> + return TestFail;
> + }
> +
> + data = file.map(4096, 8192);
> + if (data.empty()) {
> + cerr << "Mapping of file region failed" << endl;
> + return TestFail;
> + }
> +
> + if (data.size() != 8192) {
> + cerr << "Mapping of file region has invalid size" << endl;
> + return TestFail;
> + }
> +
> + if (!file.unmap(data.data())) {
> + cerr << "Unmapping of file region failed" << endl;
> + return TestFail;
> + }
> +
> + file.close();
> +
> + /* Test private mapping. */
> + file.setFileName(fileName_);
> + file.open(File::ReadWrite);
> +
> + data = file.map(0, -1, File::MapPrivate);
> + if (data.empty()) {
> + cerr << "Private mapping failed" << endl;
> + return TestFail;
> + }
> +
> + std::string str{ reinterpret_cast<char *>(data.data()), data.size() };
> + if (str != "libcamera") {
> + cerr << "Invalid contents of private mapping" << endl;
> + return TestFail;
> + }
> +
> + memcpy(data.data(), "LIBCAMERA", 9);
> +
> + if (!file.unmap(data.data())) {
> + cerr << "Private unmapping failed" << endl;
> + return TestFail;
> + }
> +
> + data = file.map();
> +
> + str = { reinterpret_cast<char *>(data.data()), data.size() };
> + if (str != "libcamera") {
> + cerr << "Private mapping changed file contents" << endl;
> + return TestFail;
> + }
> +
> + /* Test shared mapping. */
> + data = file.map();
> + if (data.empty()) {
> + cerr << "Shared mapping failed" << endl;
> + return TestFail;
> + }
> +
> + memcpy(data.data(), "LIBCAMERA", 9);
> +
> + if (!file.unmap(data.data())) {
> + cerr << "Shared unmapping failed" << endl;
> + return TestFail;
> + }
> +
> + data = file.map();
> +
> + str = { reinterpret_cast<char *>(data.data()), data.size() };
> + if (str != "LIBCAMERA") {
> + cerr << "Shared mapping failed to change file contents"
> + << endl;
> + return TestFail;
> + }
> +
> + return TestPass;
> + }
> +
> + void cleanup()
> + {
> + unlink(fileName_.c_str());
> + }
> +
> +private:
> + std::string fileName_;
> +};
> +
> +TEST_REGISTER(FileTest)
> diff --git a/test/meson.build b/test/meson.build
> index 8ab58ac15a2a..5a45a85effd3 100644
> --- a/test/meson.build
> +++ b/test/meson.build
> @@ -26,6 +26,7 @@ internal_tests = [
> ['event', 'event.cpp'],
> ['event-dispatcher', 'event-dispatcher.cpp'],
> ['event-thread', 'event-thread.cpp'],
> + ['file', 'file.cpp'],
> ['file-descriptor', 'file-descriptor.cpp'],
> ['message', 'message.cpp'],
> ['object', 'object.cpp'],
> --
> Regards,
>
> Laurent Pinchart
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
--
Regards,
Niklas Söderlund
More information about the libcamera-devel
mailing list