[libcamera-devel] [PATCH v4 6/6] DNI: libcamera: sensor: ov5670: Add lens properties
Niklas Söderlund
niklas.soderlund at ragnatech.se
Wed Apr 8 01:09:21 CEST 2020
Hi Jacopo,
Thanks for your discussion points ;-)
On 2020-03-26 15:59:27 +0100, Jacopo Mondi wrote:
> Register lens properties in the ov5670 sensor handler.
>
> This patch is not intended for merge as we know lens properties do no
> belong to the sensor handler, but I am including it anyhow to trigger
> discussions on where they would be more appropriately defined.
>
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> ---
> src/libcamera/sensor/ov5670.cpp | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/libcamera/sensor/ov5670.cpp b/src/libcamera/sensor/ov5670.cpp
> index d7339b9792e1..8c6a6114c9bf 100644
> --- a/src/libcamera/sensor/ov5670.cpp
> +++ b/src/libcamera/sensor/ov5670.cpp
> @@ -46,6 +46,12 @@ int OV5670::initProperties()
> properties::BayerFilterGRBG);
> properties_.set(properties::ISOSensitivityRange, { 50, 800 });
>
> + /* Lens Properties. */
> + properties_.set(properties::LensApertures, { 0.0f });
> + properties_.set(properties::LensFocalLengths, { 3.69f });
Would it make sens to try and record aperture information in device
tree? It is one form of hardware description right? We still will need a
way to express them some other way, maybe in a platform configuration
file?
> + properties_.set(properties::LensHyperfocalDistances, { 0.0f });
> + properties_.set(properties::LensMinimumFocusDistance, 3.69f);
For these I'm not sure as i recall my optics they some what depends to
some degree on the properties above?
> +
> return CameraSensor::initProperties();
> }
>
> --
> 2.25.1
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
--
Regards,
Niklas Söderlund
More information about the libcamera-devel
mailing list