[libcamera-devel] [PATCH 2/3] libcamera: camera: Exclude streams whose configuration cannot be updated
Umang Jain
email at uajain.com
Tue Apr 14 09:06:58 CEST 2020
This prevents a null-deference below in the loop.
Pointed out by Coverity DefectId=279069
Signed-off-by: Umang Jain <email at uajain.com>
---
src/libcamera/camera.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp
index 8c3bb2c..926e414 100644
--- a/src/libcamera/camera.cpp
+++ b/src/libcamera/camera.cpp
@@ -777,9 +777,11 @@ int Camera::configure(CameraConfiguration *config)
p_->activeStreams_.clear();
for (const StreamConfiguration &cfg : *config) {
Stream *stream = cfg.stream();
- if (!stream)
+ if (!stream) {
LOG(Camera, Fatal)
<< "Pipeline handler failed to update stream configuration";
+ continue;
+ }
stream->configuration_ = cfg;
p_->activeStreams_.insert(stream);
--
2.26.0
More information about the libcamera-devel
mailing list