[libcamera-devel] [PATCH 4/4] test: log: log_process: Close open fds on error paths

[Kieran Bingham]

Hi Umang

On 13/04/2020 11:46, Umang Jain wrote:
> Pointed out by Coverity DefectId=279097

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> Signed-off-by: Umang Jain <email at uajain.com>
> ---
>  test/log/log_process.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/test/log/log_process.cpp b/test/log/log_process.cpp
> index 2df4aa4..88baa27 100644
> --- a/test/log/log_process.cpp
> +++ b/test/log/log_process.cpp
> @@ -106,6 +106,7 @@ protected:
>  		memset(buf, 0, sizeof(buf));
>  		if (read(fd, buf, sizeof(buf)) < 0) {
>  			cerr << "Failed to read tmp log file" << endl;
> +			close(fd);
>  			return TestFail;
>  		}
>  		close(fd);
> 

-- 
Regards
--
Kieran