[libcamera-devel] [PATCH 3/3] test: v4l2_videodevice: buffer_cache: Fail the test if no buffer from cache is obtained

[Umang Jain]

Hi Laurent,

On Wed, Apr 15, 2020 at 00:56, Laurent Pinchart 
<laurent.pinchart at ideasonboard.com> wrote:
> Hi Umang,
> 
> Thank you for the patch.
> 
> On Tue, Apr 14, 2020 at 07:06:59AM +0000, Umang Jain wrote:
>>  Failing the test guards against negative index (-ENOENT in this 
>> case)
>>  being passed to V4L2BufferCache::put().
> 
> Can this happens in practice ?

Well, V4L2BufferCache::put() accepts only unsigned int argument, so I 
would say, it won't happen in practice.
Still the patches seems correct to me but commit message should be 
tweaked, is that right?


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20200415/03e443e9/attachment.htm>