[libcamera-devel] [PATCH v2 0/2] Coverity scans fixes

Umang Jain email at uajain.com
Wed Apr 15 17:04:13 CEST 2020


This is the v2 for initial covierity scan fixes I sent.
Changelog:
* test: ipc: unixsocket: Close open fds on error paths
   - Use of FileDescriptor as asked by Laurent. I found this to be a bit
     tricky and I am not sure if opening new fds in prepareFDs, frees them down
     the line. The tests states comments like "Test fire and forget"  so I am not
     sure what's the level of pedanticism we need. Happy to re-work though.
* test: log: log_api: Close open fds on error paths
   - Cleanup logSetFile(path) error path too as pointed out by Kieran.

Umang Jain (2):
  test: ipc: unixsocket: Close open fds on error paths
  test: log: log_api: Close open fds on error paths

 test/ipc/unixsocket.cpp | 19 ++++++++++++-------
 test/log/log_api.cpp    |  2 ++
 2 files changed, 14 insertions(+), 7 deletions(-)

-- 
2.26.0



More information about the libcamera-devel mailing list