[libcamera-devel] [PATCH] libcamera: Make IPA module signing mandatory for the meantime

Laurent Pinchart laurent.pinchart at ideasonboard.com
Thu Apr 16 13:57:40 CEST 2020


IPA module signing is optional, but when not available due to missing
dependencies, we hit failures due to a not fully implemented IPA
isolation. Make module signing mandatory until isolation is functional.

Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 README.rst                | 2 +-
 src/libcamera/meson.build | 2 +-
 src/meson.build           | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/README.rst b/README.rst
index da3cc64966b0..40d45196c7d6 100644
--- a/README.rst
+++ b/README.rst
@@ -66,7 +66,7 @@ for documentation: [optional]
 for gstreamer: [optional]
 	libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev
 
-for IPA module signing: [optional]
+for IPA module signing: [required]
         libgnutls28-dev openssl
 
 for qcam: [optional]
diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
index dcd2fb4900e6..874d25904693 100644
--- a/src/libcamera/meson.build
+++ b/src/libcamera/meson.build
@@ -62,7 +62,7 @@ subdir('proxy')
 
 libatomic = cc.find_library('atomic', required : false)
 libdl = cc.find_library('dl')
-libgnutls = cc.find_library('gnutls', required : false)
+libgnutls = cc.find_library('gnutls', required : true)
 libudev = dependency('libudev', required : false)
 
 if libgnutls.found()
diff --git a/src/meson.build b/src/meson.build
index 296682758613..f605a420c3ee 100644
--- a/src/meson.build
+++ b/src/meson.build
@@ -2,7 +2,7 @@ if get_option('android')
     subdir('android')
 endif
 
-openssl = find_program('openssl', required : false)
+openssl = find_program('openssl', required : true)
 if openssl.found()
     ipa_gen_priv_key = find_program('ipa/gen-ipa-priv-key.sh')
     ipa_priv_key = custom_target('ipa-priv-key',
-- 
Regards,

Laurent Pinchart



More information about the libcamera-devel mailing list