[libcamera-devel] [PATCH 1/2] cam: Rename OptProps to OptListProperties

[Jacopo Mondi]

Hi Laurent,

On Sat, Apr 25, 2020 at 02:42:36AM +0300, Laurent Pinchart wrote:
> The name OptProps is not very clear, spell it out fully. The command
> line options are not changed.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

Thanks
  j

> ---
>  src/cam/main.cpp | 4 ++--
>  src/cam/main.h   | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/cam/main.cpp b/src/cam/main.cpp
> index 718740f49762..340849e74ddd 100644
> --- a/src/cam/main.cpp
> +++ b/src/cam/main.cpp
> @@ -182,7 +182,7 @@ int CamApp::parseOptions(int argc, char *argv[])
>  	parser.addOption(OptInfo, OptionNone,
>  			 "Display information about stream(s)", "info");
>  	parser.addOption(OptList, OptionNone, "List all cameras", "list");
> -	parser.addOption(OptProps, OptionNone, "List cameras properties",
> +	parser.addOption(OptListProperties, OptionNone, "List cameras properties",
>  			 "list-properties");
>
>  	options_ = parser.parse(argc, argv);
> @@ -339,7 +339,7 @@ int CamApp::run()
>  		}
>  	}
>
> -	if (options_.isSet(OptProps)) {
> +	if (options_.isSet(OptListProperties)) {
>  		ret = listProperties();
>  		if (ret)
>  			return ret;
> diff --git a/src/cam/main.h b/src/cam/main.h
> index afcad4353b7d..d23c6dfb202e 100644
> --- a/src/cam/main.h
> +++ b/src/cam/main.h
> @@ -14,7 +14,7 @@ enum {
>  	OptHelp = 'h',
>  	OptInfo = 'I',
>  	OptList = 'l',
> -	OptProps = 'p',
> +	OptListProperties = 'p',
>  	OptStream = 's',
>  };
>
> --
> Regards,
>
> Laurent Pinchart
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel