[libcamera-devel] [PATCH 04/11] libcamera: ipa_proxy: Don't include <iostream>

[Laurent Pinchart]

Hi Kieran,

On Mon, Apr 27, 2020 at 11:27:32AM +0100, Kieran Bingham wrote:
> On 27/04/2020 04:17, Laurent Pinchart wrote:
> > The iostream header isn't needed. Drop it.
> 
> Hrm ... is there a way to detect this with any tooling that could then
> be integrated into checkstyle.py somehow?
> 
> Can the compiler tell us what files are included redundantly?

I'm not aware of a way to do so, but if there's one, I'll review patches
:-)

> Still, regardless:
> 
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> 
> > Fixes: c2a8217df54c ("libcamera: add IPA proxy")
> > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > ---
> >  src/libcamera/ipa_proxy.cpp | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp
> > index 22b246be5797..43ac9afc25cb 100644
> > --- a/src/libcamera/ipa_proxy.cpp
> > +++ b/src/libcamera/ipa_proxy.cpp
> > @@ -13,8 +13,6 @@
> >  #include "log.h"
> >  #include "utils.h"
> >  
> > -#include <iostream>
> > -
> >  /**
> >   * \file ipa_proxy.h
> >   * \brief IPA Proxy

-- 
Regards,

Laurent Pinchart