[libcamera-devel] [PATCH] libcamera: ipa_manager: Fix build path comments

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Wed, Apr 29, 2020 at 04:19:10PM +0100, Kieran Bingham wrote:
> The comments describe functionality before libcameraBuildPath() was
> adapted from libcameraPath() to return the root of the build, and
> described having to take a relative path.
> 
> This is no longer the case, and the comment is inaccurate. Fix it.
> 
> Fixes: 1b8ac8473c94 ("libcamera: utils: Adapt libcameraPath to match use cases")
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/ipa_manager.cpp | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp
> index df3786797010..1faa3dd38188 100644
> --- a/src/libcamera/ipa_manager.cpp
> +++ b/src/libcamera/ipa_manager.cpp
> @@ -114,10 +114,7 @@ IPAManager::IPAManager()
>  
>  	/*
>  	 * When libcamera is used before it is installed, load IPAs from the
> -	 * same build directory as the libcamera library itself. This requires
> -	 * identifying the path of the libcamera.so, and referencing a relative
> -	 * path for the IPA from that point. We need to recurse one level of
> -	 * sub-directories to match the build tree.
> +	 * same build directory as the libcamera library itself.
>  	 */
>  	std::string root = utils::libcameraBuildPath();
>  	if (!root.empty()) {

-- 
Regards,

Laurent Pinchart