[libcamera-devel] [PATCH] libcamera: Build IPA module signatures by default

Laurent Pinchart laurent.pinchart at ideasonboard.com
Thu Apr 30 03:17:09 CEST 2020


Commit 7206035ee609 ("libcamera: Regenerate IPA module signatures at
install time") replaced installation of the IPA module signatures with
an install script that signs all modules. While doing so, it
inadvertently also disabled generation of the signature at build time by
default. This breaks running libcamera binaries from the build
directory. Fix it.

Fixes: 7206035ee609 ("libcamera: Regenerate IPA module signatures at install time")
Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 src/ipa/rkisp1/meson.build | 3 ++-
 src/ipa/vimc/meson.build   | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build
index 6c6aa82f3b29..d7127ea8d1e9 100644
--- a/src/ipa/rkisp1/meson.build
+++ b/src/ipa/rkisp1/meson.build
@@ -14,5 +14,6 @@ if ipa_sign_module
                   input : mod,
                   output : ipa_name + '.so.sign',
                   command : [ ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@' ],
-                  install : false)
+                  install : false,
+                  build_by_default : true)
 endif
diff --git a/src/ipa/vimc/meson.build b/src/ipa/vimc/meson.build
index 253847e19d6b..22296a029642 100644
--- a/src/ipa/vimc/meson.build
+++ b/src/ipa/vimc/meson.build
@@ -14,7 +14,8 @@ if ipa_sign_module
                   input : mod,
                   output : ipa_name + '.so.sign',
                   command : [ ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@' ],
-                  install : false)
+                  install : false,
+                  build_by_default : true)
 endif
 
 subdir('data')
-- 
Regards,

Laurent Pinchart



More information about the libcamera-devel mailing list