[libcamera-devel] [PATCH] libcamera: v4l2_pixelformat: Fix V4L2_PIX_FMT_SBGGR10P format

[Kieran Bingham]

On 30/04/2020 15:01, Laurent Pinchart wrote:
> The V4L2_PIX_FMT_SBGGR10P format was misspecified as
> V4L2_PIX_FMT_SBGGR10. Fix it.
> 
> Fixes: 00d639d951e7 ("libcamera: formats: Add support for 8-, 10- and 12-bit Bayer formats")
> Reported-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Ooops.

I'm sure I even looked through matching the {SGBR}s in both parts. Must
have missed checking/matching the Ps :-(

<don't say it ... don't say it ...>
  Maybe it would have been more visible in a table as the alignment
would be off ..
<I said don't say it...> :-D

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>


> ---
>  src/libcamera/v4l2_pixelformat.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp
> index fd7e2d286f3f..561f9327780a 100644
> --- a/src/libcamera/v4l2_pixelformat.cpp
> +++ b/src/libcamera/v4l2_pixelformat.cpp
> @@ -77,7 +77,7 @@ const std::map<V4L2PixelFormat, PixelFormat> vpf2pf{
>  	{ V4L2PixelFormat(V4L2_PIX_FMT_SGBRG10), PixelFormat(DRM_FORMAT_SGBRG10) },
>  	{ V4L2PixelFormat(V4L2_PIX_FMT_SGRBG10), PixelFormat(DRM_FORMAT_SGRBG10) },
>  	{ V4L2PixelFormat(V4L2_PIX_FMT_SRGGB10), PixelFormat(DRM_FORMAT_SRGGB10) },
> -	{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR10),
> +	{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR10P),
>  	  PixelFormat(DRM_FORMAT_SBGGR10, MIPI_FORMAT_MOD_CSI2_PACKED) },
>  	{ V4L2PixelFormat(V4L2_PIX_FMT_SGBRG10P),
>  	  PixelFormat(DRM_FORMAT_SGBRG10, MIPI_FORMAT_MOD_CSI2_PACKED) },
> 

-- 
Regards
--
Kieran