[libcamera-devel] [PATCH v2 09/12] android: camera_device: Report configuration changes from validate()

Kieran Bingham kieran.bingham at ideasonboard.com
Mon Aug 3 18:18:13 CEST 2020


When we call validate on a configuration, if there are any adjustments
on the configuration, we fail without showing why.

Display the stream configuration after the validate stage to aid
debugging stream startup failures.

Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
---
 src/android/camera_device.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
index 9f3f3315aed4..ae52a5ca8b86 100644
--- a/src/android/camera_device.cpp
+++ b/src/android/camera_device.cpp
@@ -987,7 +987,11 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)
 	case CameraConfiguration::Valid:
 		break;
 	case CameraConfiguration::Adjusted:
-		LOG(HAL, Info) << "Camera configuration adjusted";
+		LOG(HAL, Info) << "Camera configuration adjusted:";
+
+		for (const StreamConfiguration &cfg : *config_)
+			LOG(HAL, Info) << " : " << cfg.toString();
+
 		config_.reset();
 		return -EINVAL;
 	case CameraConfiguration::Invalid:
-- 
2.25.1



More information about the libcamera-devel mailing list