[libcamera-devel] [PATCH] libcamera: ipu3: Fix compilation issues with gcc5

[Laurent Pinchart]

Hi Jacopo,

Thank you for the patch.

On Mon, Aug 03, 2020 at 06:28:11PM +0200, Jacopo Mondi wrote:
> GCC5 does not provide prototypes for the math library functions defined
> in the math.h header for the std:: namespace.
> 
> Include the C++ <cmath> header in place of <math.h> as it defines
> overloads for the std::abs and std::fmod function.
> 
> This goes intentionally against the libcamera coding guidelines, and
> is reported as warning by checkpatch.py.

I'm considering adjusting the guidelines specifically for cmath, as the
math function overloads are really nice to have, and should do the right
thing by default.

> Fixes: 968ab9bad0ed ("libcamera: ipu3: imgu: Calculate ImgU pipe configuration")
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Please push :-)

> ---
>  src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp
> index b7593ceb3672..eb829e096561 100644
> --- a/src/libcamera/pipeline/ipu3/imgu.cpp
> +++ b/src/libcamera/pipeline/ipu3/imgu.cpp
> @@ -7,8 +7,8 @@
>  
>  #include "imgu.h"
>  
> +#include <cmath>
>  #include <limits>
> -#include <math.h>
>  
>  #include <linux/media-bus-format.h>
>  

-- 
Regards,

Laurent Pinchart