[libcamera-devel] [PATCH v4 10/13] android: camera_device: Report configuration changes from validate()
Kieran Bingham
kieran.bingham at ideasonboard.com
Wed Aug 5 17:15:04 CEST 2020
When we call validate on a configuration, if there are any adjustments
on the configuration, we fail without showing why.
Display the stream configuration after the validate stage to aid
debugging stream startup failures.
Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
---
v4
- hyphenate instead.
---
src/android/camera_device.cpp | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
index a5c135ce03eb..397161a9ab12 100644
--- a/src/android/camera_device.cpp
+++ b/src/android/camera_device.cpp
@@ -1084,6 +1084,10 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)
break;
case CameraConfiguration::Adjusted:
LOG(HAL, Info) << "Camera configuration adjusted";
+
+ for (const StreamConfiguration &cfg : *config_)
+ LOG(HAL, Info) << " - " << cfg.toString();
+
config_.reset();
return -EINVAL;
case CameraConfiguration::Invalid:
--
2.25.1
More information about the libcamera-devel
mailing list