[libcamera-devel] [PATCH 1/7] libcamera: properties: Add model property

[Laurent Pinchart]

Hi Niklas,

Thank you for the patch.

On Thu, Aug 06, 2020 at 03:09:31PM +0200, Niklas Söderlund wrote:
> The model property describes the camera model string.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
> ---
>  src/libcamera/property_ids.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml
> index 74ad0195d6310367..5c597bfc6e2d4089 100644
> --- a/src/libcamera/property_ids.yaml
> +++ b/src/libcamera/property_ids.yaml
> @@ -387,6 +387,11 @@ controls:
>                                |                    |
>                                +--------------------+
>  
> +  - Model:
> +      type: string
> +      description: |
> +        Camera model name

This needs more documentation, possibly with examples. It also needs to
define how the string should be encoded (likely UTF-8, but for some
properties we may want to restrict it to ASCII). The encoding should
probably be defined somewhere globally.

> +
>    - UnitCellSize:
>        type: Size
>        description: |

-- 
Regards,

Laurent Pinchart