[libcamera-devel] [PATCH] libcamera: pipeline: rkisp1: Fix array size of formats

[Jacopo Mondi]

Hi Niklas,

On Thu, Aug 06, 2020 at 04:14:35PM +0200, Niklas Söderlund wrote:
> When switching from V4L2 to DRM pixel formats V4L2_PIX_FMT_GREY was
> dropped form the list of supported formats but the arrays size was never
> decreased, fix this.
>
> Fixes: 448716d8f7518579 ("libcamera: Switch PixelFormat to DRM FourCC values")
> Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

Good catch. What happens if we over allocate the array ?

Anyway:
Acked-by: Jacopo Mondi <jacopo at jmondi.org>

Thanks
  j

> ---
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index b7609cbc8f363135..32fdaed7c661ae74 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -461,7 +461,7 @@ RkISP1CameraConfiguration::RkISP1CameraConfiguration(Camera *camera,
>
>  CameraConfiguration::Status RkISP1CameraConfiguration::validate()
>  {
> -	static const std::array<PixelFormat, 8> formats{
> +	static const std::array<PixelFormat, 7> formats{
>  		formats::YUYV,
>  		formats::YVYU,
>  		formats::VYUY,
> --
> 2.28.0
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel