[libcamera-devel] [PATCH v3 4/5] android: camera_device: Add a getter to get libcamera::Camera pointer

[Laurent Pinchart]

Hi Umang,

Thank you for the patch.

On Mon, Aug 17, 2020 at 08:26:40PM +0000, Umang Jain wrote:
> Add a public member function to get the libcamera::Camera pointer
> associated with the CameraDevice. This will help to find the CameraDevice
> object in CameraHalManager when the hotplug support is extended in the
> android layer.

s/android/Android/

> Signed-off-by: Umang Jain <email at uajain.com>
> ---
>  src/android/camera_device.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/android/camera_device.h b/src/android/camera_device.h
> index b149043..7908bc0 100644
> --- a/src/android/camera_device.h
> +++ b/src/android/camera_device.h
> @@ -57,6 +57,7 @@ public:
>  
>  	unsigned int id() const { return id_; }
>  	camera3_device_t *camera3Device() { return &camera3Device_; }
> +	const libcamera::Camera *camera() { return camera_.get(); }

You can make this a const method

	const libcamera::Camera *camera() const { return camera_.get(); }

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

>  
>  	int facing() const { return facing_; }
>  	int orientation() const { return orientation_; }

-- 
Regards,

Laurent Pinchart