[libcamera-devel] [PATCH] libcamera: object: Fix deleteLater() sample code

Umang Jain email at uajain.com
Fri Aug 21 08:40:28 CEST 2020


Instead of using "delete obj" in the custom deleter of the shared
object, we should have been using the "obj->deleteLater()" to explain
how the deleteLater() API should be used in practice.

Fixes: 9558886f7a85 ("libcamera: object: Add deleteLater() support)
Signed-off-by: Umang Jain <email at uajain.com>
---
 src/libcamera/object.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libcamera/object.cpp b/src/libcamera/object.cpp
index 647ccda..cd83c68 100644
--- a/src/libcamera/object.cpp
+++ b/src/libcamera/object.cpp
@@ -125,7 +125,7 @@ Object::~Object()
  *     struct Deleter : std::default_delete<MyObject> {
  *             void operator()(MyObject *obj)
  *             {
- *                     delete obj;
+ *                     obj->deleteLater();
  *             }
  *     };
  *
-- 
2.26.2



More information about the libcamera-devel mailing list