[libcamera-devel] [PATCH v2 3/4] libcamera: camera_sensor: Initialize PixelArray properties
Jacopo Mondi
jacopo at jmondi.org
Wed Dec 2 14:53:53 CET 2020
Initialize pixel array properties 'PixelArraySize' and
'PixelArrayActiveAreas' by inspecting the V4L2 CROP_BOUNDS and
CROP_DEFAULT selection targets.
The properties are registered only if the sensor subdevice support
the above mentioned selection targets.
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
---
src/libcamera/camera_sensor.cpp | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp
index 7e6995c43010..1628ba9c892b 100644
--- a/src/libcamera/camera_sensor.cpp
+++ b/src/libcamera/camera_sensor.cpp
@@ -288,6 +288,25 @@ int CameraSensor::initProperties()
propertyValue = 0;
properties_.set(properties::Rotation, propertyValue);
+ Rectangle bounds;
+ ret = subdev_->getSelection(pad_, V4L2_SEL_TGT_CROP_BOUNDS, &bounds);
+ if (!ret)
+ properties_.set(properties::PixelArraySize, bounds.size());
+
+ Rectangle crop;
+ ret = subdev_->getSelection(pad_, V4L2_SEL_TGT_CROP_DEFAULT, &crop);
+ if (!ret) {
+ /*
+ * V4L2_SEL_TGT_CROP_DEFAULT and V4L2_SEL_TGT_CROP_BOUNDS are
+ * defined relatively to the sensor full pixel array size,
+ * while properties::PixelArrayActiveAreas is defined relatively
+ * to properties::PixelArraySize. Adjust it.
+ */
+ crop.x -= bounds.x;
+ crop.y -= bounds.y;
+ properties_.set(properties::PixelArrayActiveAreas, { crop });
+ }
+
return 0;
}
--
2.29.1
More information about the libcamera-devel
mailing list