[libcamera-devel] [PATCH v3 0/3] Pass controls on camera:start()

Naushir Patuck naush at raspberrypi.com
Fri Dec 4 16:31:18 CET 2020


Hi,

Here is patchset v3 for the work on passing controls on camera::start().  I have addressed Jacopo's review comments, and rebased to the top of master.

Thanks,
Naush

Naushir Patuck (3):
  libcamera: pipeline: Pass libcamera controls into
    pipeline_handler::start()
  libcamera: ipa: Pass a set of controls and return results from
    ipa::start()
  pipeline: ipa: raspberrypi: Pass controls to IPA on start

 Documentation/guides/pipeline-handler.rst     |  4 +-
 include/libcamera/camera.h                    |  2 +-
 .../libcamera/internal/ipa_context_wrapper.h  |  3 +-
 include/libcamera/internal/pipeline_handler.h |  2 +-
 include/libcamera/ipa/ipa_interface.h         |  3 +-
 include/libcamera/ipa/raspberrypi.h           |  1 +
 src/ipa/libipa/ipa_interface_wrapper.cpp      |  4 +-
 src/ipa/raspberrypi/raspberrypi.cpp           | 55 ++++++++++++-------
 src/ipa/rkisp1/rkisp1.cpp                     |  3 +-
 src/ipa/vimc/vimc.cpp                         |  6 +-
 src/libcamera/camera.cpp                      | 11 ++--
 src/libcamera/ipa_context_wrapper.cpp         |  5 +-
 src/libcamera/ipa_interface.cpp               |  7 +++
 src/libcamera/pipeline/ipu3/ipu3.cpp          |  4 +-
 .../pipeline/raspberrypi/raspberrypi.cpp      | 22 ++++++--
 src/libcamera/pipeline/rkisp1/rkisp1.cpp      |  7 ++-
 src/libcamera/pipeline/simple/simple.cpp      |  4 +-
 src/libcamera/pipeline/uvcvideo/uvcvideo.cpp  |  4 +-
 src/libcamera/pipeline/vimc/vimc.cpp          |  7 ++-
 src/libcamera/pipeline_handler.cpp            |  1 +
 src/libcamera/proxy/ipa_proxy_linux.cpp       |  3 +-
 src/libcamera/proxy/ipa_proxy_thread.cpp      | 13 +++--
 test/ipa/ipa_interface_test.cpp               |  3 +-
 test/ipa/ipa_wrappers_test.cpp                |  5 +-
 24 files changed, 117 insertions(+), 62 deletions(-)

-- 
2.25.1



More information about the libcamera-devel mailing list